[EuiCollapsedNavButton][a11y] Update aria-label for enhanced screen reader navigation#7740
Merged
cee-chen merged 5 commits intoelastic:mainfrom May 7, 2024
Merged
[EuiCollapsedNavButton][a11y] Update aria-label for enhanced screen reader navigation#7740cee-chen merged 5 commits intoelastic:mainfrom
aria-label for enhanced screen reader navigation#7740cee-chen merged 5 commits intoelastic:mainfrom
Conversation
… reader navigation Closes: elastic/security-team#8947
mgadewoll
reviewed
May 7, 2024
src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/collapsed_nav_button.tsx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
May 7, 2024
cee-chen
reviewed
May 7, 2024
1 task
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
Contributor
|
@1Copenut before I fix the snapshots, do you mind checking what the new punctuation experience is like on JAWS? |
Contributor
Author
|
@cee-chen @1Copenut @mgadewoll Thanks, although we have already used the version with |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
Contributor
The new experience is solid. I checked NVDA + Chrome and FF, and JAWS + Chrome. All three announced the name, short pause, then "quick navigation menu". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/security-team/issues/8947
Summary
The Security icon popover announces "Security, button", then "Security, description" to screen readers. This is caused by the aria-label and tooltip aria-describedby text being the same. Screen reader users do not have context that this will open the Security Solution quick navigation popover (with just the top-level links). We can improve this by updating the information in the EUI Tooltip content prop. Screenshot and linked CodeSandbox below.
What was changed?:
Screen:
General checklist
@defaultif default values are missing) and playground toggles